martok/js-darktree
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add ending semicolon to improve compatibility #1

New issue
Closed
opened 2022-12-02 04:31:13 +00:00 by SeaHOH · 2 comments
SeaHOH commented 2022-12-02 04:31:13 +00:00 (Migrated from github.com)
Copy link

ad15e611e8/src/darktree.js (L1071)

https://github.com/martok/js-darktree/blob/ad15e611e89c4002ac655f05f86d25a5744f29b1/src/darktree.js#L1071
martok commented 2022-12-02 12:01:41 +00:00 (Migrated from github.com)
Copy link

Compatibility with what? Pale Moon accepts it so Spidermonkey is OK, Terser accepts it so V8 is OK.

That's EOF, not even a linebreak where semicolon insertion could go wrong?

Compatibility with what? Pale Moon accepts it so Spidermonkey is OK, Terser accepts it so V8 is OK. That's EOF, not even a linebreak where semicolon insertion could go wrong?
SeaHOH commented 2022-12-02 19:27:40 +00:00 (Migrated from github.com)
Copy link

Someone maybe direct write the whole content to HTML output as is, if a bracket pair follow up it, then cause error.

Someone maybe direct write the whole content to HTML output as is, if a bracket pair follow up it, then cause error.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: martok/js-darktree#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?